liubao68 commented on a change in pull request #791: [SCB-716] Implementation 
of Local Service Registry Demo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/791#discussion_r200617732
 
 

 ##########
 File path: demo/demo-local-service-registry/local-registry-client/pom.xml
 ##########
 @@ -0,0 +1,54 @@
+<?xml version="1.0"?>
 
 Review comment:
   Can you move these codes to samples folder? Java-chassis demo folder is for 
integration tests . We are planning to change it but got no time to deal this. 
   And add a README.md for this sample project to learn what it is done and how 
to run this sample. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to