liubao68 commented on a change in pull request #891: [SCB-887]aysnc servlet
timeout is too short and may block container pool when tasks are timeout
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/891#discussion_r215156836
##########
File path:
transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/HighwayConfig.java
##########
@@ -18,13 +18,26 @@
package org.apache.servicecomb.transport.highway;
import com.netflix.config.DynamicIntProperty;
+import com.netflix.config.DynamicLongProperty;
import com.netflix.config.DynamicPropertyFactory;
import com.netflix.config.DynamicStringProperty;
public final class HighwayConfig {
private HighwayConfig() {
}
+ public static final String KEY_SERVICECOMB_REQUEST_WAIT_IN_POOL_TIMEOUT =
"servicecomb.highway.server.requestWaitInPoolTimeout";
Review comment:
2 item is more flexible. I test it for highway this configuration works much
better than rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
