liubao68 commented on a change in pull request #891: [SCB-887]aysnc servlet
timeout is too short and may block container pool when tasks are timeout
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/891#discussion_r215157072
##########
File path:
transports/transport-rest/transport-rest-servlet/src/main/java/org/apache/servicecomb/transport/rest/servlet/RestAsyncListener.java
##########
@@ -63,24 +64,28 @@ public void onTimeout(AsyncEvent event) throws IOException
{
// to avoid concurrent, must lock request
ServletRequest request = event.getSuppliedRequest();
HttpServletRequestEx requestEx = (HttpServletRequestEx)
request.getAttribute(RestConst.REST_REQUEST);
+ LOGGER.error("Rest request timeout, method {}, path {}.",
requestEx.getMethod(), requestEx.getRequestURI());
Review comment:
I disabled it with -1 by default. And I think it's better to leave timeout
setting to users if they really need it in some scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
