heyile commented on a change in pull request #947: [SCB-837] make http2 production ready URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r226131786
########## File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java ########## @@ -133,7 +139,24 @@ public void disconnected(Object webSocketMetric) { @Override public DefaultHttpSocketMetric connected(SocketAddress remoteAddress, String remoteName) { - return new DefaultHttpSocketMetric(null); + // when host of createEndpoint is not ip but a hostName + // get from remoteAddress will return null + // in this time need to try again with remoteName + // connected is a low frequency method, this try logic will not cause performance problem + + DefaultClientEndpointMetric clientEndpointMetric = this.clientEndpointMetricManager + .getClientEndpointMetric(remoteAddress); + if (clientEndpointMetric == null) { + LOGGER.warn("can not find endpointMetric directly by remoteAddress {}, try again with remoteName {}", Review comment: ok, get ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services