heyile commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r226934287
##########
File path:
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/deploy/Deploys.java
##########
@@ -187,6 +194,23 @@ private void initBaseProducer() {
baseProducer = new MicroserviceDeploy(definition);
}
+
+ private void initBaseHttp2Producer() {
+ MicroserviceDeployDefinition definition = new
MicroserviceDeployDefinition();
+ definition.setDeployName("baseHttp2Producer");
+ definition.setCmd("it-producer");
+ definition.setArgs(new String[] {});
+ definition.setArgs(new String[]
{"-Dservicecomb.rest.address=0.0.0.0:0?protocol=http2",
+ "-Dservicecomb.highway.address=0.0.0.0:0?protocol=http2"});
Review comment:
do not need ? or do need ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
