wujimin commented on a change in pull request #990: [SCB-986] Cache instances result in CseDiscoveryClient URL: https://github.com/apache/servicecomb-java-chassis/pull/990#discussion_r232708811
########## File path: spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseDiscoveryClient.java ########## @@ -44,23 +46,62 @@ public String description() { @Override public List<ServiceInstance> getInstances(final String serviceId) { + + class InstanceDiscoveryFilter implements DiscoveryFilter { + + @Override + public int getOrder() { + return Integer.MAX_VALUE; + } + + @Override + public DiscoveryTreeNode discovery(DiscoveryContext context, DiscoveryTreeNode parent) { + return createDiscoveryTreeNode(context, parent); Review comment: there is no cache logic, because create new node each time, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services