wujimin commented on a change in pull request #990: [SCB-986] Cache instances result in CseDiscoveryClient URL: https://github.com/apache/servicecomb-java-chassis/pull/990#discussion_r233159768
########## File path: spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseDiscoveryClient.java ########## @@ -44,24 +51,55 @@ public String description() { @Override public List<ServiceInstance> getInstances(final String serviceId) { + class InstanceDiscoveryFilter implements DiscoveryFilter { Review comment: put class InstanceDiscoveryFilter in "getInstances", make "getInstances" logic not clear ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services