wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030818
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##########
@@ -356,6 +356,30 @@ public String getSchema(String microserviceId, String
schemaId) {
syncHandler(countDownLatch, GetSchemaResponse.class, holder));
try {
countDownLatch.await();
+ } catch (Exception e) {
+ LOGGER.error("query schema exist {}/{} failed",
+ schemaId,
+ e);
+ }
+ if (holder.value != null) {
+ return holder.value.getSchema();
+ }
+
+ return null;
+ }
+
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
+ Holder<GetSchemaResponse> holder = new Holder<>();
Review comment:
do not copy code
just make global to be a parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
