wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236035433
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##########
@@ -346,19 +346,26 @@ public boolean registerSchema(String microserviceId,
String schemaId, String sch
@Override
public String getSchema(String microserviceId, String schemaId) {
+ return doGetSchema(microserviceId, schemaId, false);
+ }
+
+ private String doGetSchema(String microserviceId, String schemaId, boolean
isAggregatedServiceCenter) {
Review comment:
not "isAggregatedServiceCenter"
target is ServiceCenter Aggregator:
1.for register flow, global=false
2.for find instance flow, global=true
so the variable name better to be: global
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
