tianxiaoliang commented on a change in pull request #577: Clear no-instance 
services automatically
URL: 
https://github.com/apache/servicecomb-service-center/pull/577#discussion_r317054422
 
 

 ##########
 File path: server/core/config.go
 ##########
 @@ -17,18 +17,29 @@
 package core
 
 import (
+       "os"
+       "runtime"
+       "time"
+
        "github.com/apache/servicecomb-service-center/pkg/log"
        "github.com/apache/servicecomb-service-center/pkg/plugin"
        "github.com/apache/servicecomb-service-center/pkg/util"
        pb "github.com/apache/servicecomb-service-center/server/core/proto"
        "github.com/apache/servicecomb-service-center/version"
        "github.com/astaxie/beego"
-       "os"
-       "runtime"
 )
 
 const (
        INIT_VERSION = "0"
+
+       defaultServiceClearInterval = 12 * time.Hour //0.5 day
+       defaultServiceClearTime     = 24 * time.Hour //1 day
+
+       minServiceClearInterval = 1 * time.Second
+       minServiceClearTime     = 1 * time.Second
 
 Review comment:
   every second clear a services is impossibel senario in real world 
   
   make it to 30s

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to