tianxiaoliang commented on a change in pull request #577: Clear no-instance
services automatically
URL:
https://github.com/apache/servicecomb-service-center/pull/577#discussion_r317059137
##########
File path: server/task/clear_service.go
##########
@@ -0,0 +1,87 @@
+package task
+
+import (
+ "context"
+ "strconv"
+ "strings"
+ "time"
+
+ "github.com/apache/servicecomb-service-center/pkg/log"
+ "github.com/apache/servicecomb-service-center/pkg/util"
+ apt "github.com/apache/servicecomb-service-center/server/core"
+ pb "github.com/apache/servicecomb-service-center/server/core/proto"
+ serviceUtil
"github.com/apache/servicecomb-service-center/server/service/util"
+)
+
+// ClearNoInstanceService clears services which have no instance
+// t means a service's existence time
+func ClearNoInstanceServices(t time.Duration) error {
Review comment:
ClearNoInstanceServices that is a long function
solution: extract method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
