liubao68 commented on a change in pull request #1561: [SCB-1748] support colon
in path value
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1561#discussion_r376302692
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/PathProcessorCreator.java
##########
@@ -52,6 +54,9 @@ public Object getValue(HttpServletRequest request) {
if (value == null) {
return null;
}
+ if (value.contains(":")) {
+ return convertValue(URLDecoder.decode(value, "UTF-8"), targetType);
Review comment:
Maybe this test case is not correct. Checked the
[RFC](https://www.ietf.org/rfc/rfc2396.txt)
```
3.3. Path Component
The path component contains data, specific to the authority (or the
scheme if there is no authority component), identifying the resource
within the scope of that scheme and authority.
path = [ abs_path | opaque_part ]
path_segments = segment *( "/" segment )
segment = *pchar *( ";" param )
param = *pchar
pchar = unreserved | escaped |
":" | "@" | "&" | "=" | "+" | "$" | ","
The path may consist of a sequence of path segments separated by a
single slash "/" character. Within a path segment, the characters
"/", ";", "=", and "?" are reserved. Each path segment may include a
sequence of parameters, indicated by the semicolon ";" character.
The parameters are not significant to the parsing of relative
references.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
