liubao68 commented on a change in pull request #1561: [SCB-1748] support colon 
in path value
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1561#discussion_r376305439
 
 

 ##########
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/PathProcessorCreator.java
 ##########
 @@ -52,6 +54,9 @@ public Object getValue(HttpServletRequest request) {
       if (value == null) {
         return null;
       }
+      if (value.contains(":")) {
+        return convertValue(URLDecoder.decode(value, "UTF-8"), targetType);
 
 Review comment:
   I checked the code again. May be "encodePathParam" and "decodePathParam" 
should be used here. You need check details usage of "uriEncodePath" and 
"uriDecodePath". They are different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to