liubao68 commented on issue #1561: [SCB-1748] support colon in path value
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1561#issuecomment-585060007
 
 
   I think the current modification is not correct, need more analyse. For 
reference, you can look at 
   ```org.springframework.web.util.UriUtils```
   
   and This test case seems not correct
   ```
     @Test
     public void uriDecode_failed() {
       expectedException.expect(IllegalArgumentException.class);
       expectedException
           .expectMessage(Matchers.is("uriDecode failed, path=\":\"."));
       
expectedException.expectCause(Matchers.instanceOf(URISyntaxException.class));
   
       HttpUtils.uriDecodePath(":");
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to