tianxiaoliang commented on a change in pull request #107: #103 topic support
none label cases
URL: https://github.com/apache/servicecomb-kie/pull/107#discussion_r386230487
##########
File path: server/pubsub/struct.go
##########
@@ -86,11 +90,15 @@ func (t *Topic) Match(event *KVChangeEvent) bool {
return false
}
}
- for k, v := range t.Labels {
- if event.Labels[k] != v {
- return false
- }
+ if len(t.Labels) == 0 {
match = true
Review comment:
这里有个问题，MatchType 不生效，如果watch的label为空的话，当要求exactmatch的手，过来的事件也必须得是label为空，才能触发
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
