tianxiaoliang commented on a change in pull request #107: #103 topic support
none label cases
URL: https://github.com/apache/servicecomb-kie/pull/107#discussion_r386385117
##########
File path: server/pubsub/struct.go
##########
@@ -81,6 +85,9 @@ func ParseTopicString(s string) (*Topic, error) {
}
//Match compare event with topic
+//If the match type is set to exact in long pulling request,
+//only update request with exactly the same label will match the request and
will trigger an immediate return.
+//If no labels are set in query params, only the none label update request
will match.
Review comment:
第三行注释，不完全对，并不是only 而是 none label和label子集都会match
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
