tianxiaoliang commented on a change in pull request #129: wip: refactor apis
URL: https://github.com/apache/servicecomb-kie/pull/129#discussion_r398583830
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -35,26 +36,76 @@ import (
type KVResource struct {
}
-//Put create or update kv
+//Post create a kv
+func (r *KVResource) Post(context *restful.Context) {
+ var err error
+ project := context.ReadPathParameter(PathParameterProject)
+ kvDoc := new(model.KVDoc)
+ if err = readRequest(context, kvDoc); err != nil {
+ WriteErrResponse(context, http.StatusBadRequest, err.Error(),
common.ContentTypeText)
+ return
+ }
+ if kvDoc.Key == "" {
+ WriteErrResponse(context, http.StatusBadRequest,
common.MsgKeyMustNotBeEmpty, common.ContentTypeText)
+ return
+ }
+ domain := ReadDomain(context)
+ kvDoc.Domain = domain.(string)
+ kvDoc.Project = project
+ _, err = checkStatus(kvDoc.Status)
+ if err != nil {
+ WriteErrResponse(context, http.StatusInternalServerError,
err.Error(), common.ContentTypeText)
+ return
+ }
+ kv, err := service.KVService.Create(context.Ctx, kvDoc)
+ if err != nil {
+ openlogging.Error(fmt.Sprintf("post [%v] err:%s", kvDoc,
err.Error()))
+ if err == session.ErrKVAlreadyExists {
+ WriteErrResponse(context, http.StatusConflict,
err.Error(), common.ContentTypeText)
+ return
+ }
+ WriteErrResponse(context, http.StatusInternalServerError,
err.Error(), common.ContentTypeText)
+ return
+ }
+ err = pubsub.Publish(&pubsub.KVChangeEvent{
+ Key: kvDoc.Key,
+ Labels: kvDoc.Labels,
+ Project: project,
+ DomainID: kvDoc.Domain,
+ Action: pubsub.ActionPut,
+ })
+ if err != nil {
+ openlogging.Warn("lost kv change event when post:" +
err.Error())
+ }
+ openlogging.Info(
+ fmt.Sprintf("post [%s] success", kvDoc.Key))
Review comment:
这里打审计日志，打出key信息也没参考价值，打id吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
