tianxiaoliang commented on a change in pull request #129: wip: refactor apis
URL: https://github.com/apache/servicecomb-kie/pull/129#discussion_r399088504
##########
File path: server/resource/v1/kv_resource.go
##########
@@ -68,65 +72,104 @@ func (r *KVResource) Put(context *restful.Context) {
Action: pubsub.ActionPut,
})
if err != nil {
- openlogging.Warn("lost kv change event:" + err.Error())
+ openlogging.Warn("lost kv change event when post:" +
err.Error())
}
openlogging.Info(
- fmt.Sprintf("put [%s] success", kv.Key))
+ fmt.Sprintf("post [%s] success", kv.ID))
err = writeResponse(context, kv)
if err != nil {
openlogging.Error(err.Error())
}
}
-//GetByKey search key by label and key
-func (r *KVResource) GetByKey(rctx *restful.Context) {
+//Put update a kv
+func (r *KVResource) Put(context *restful.Context) {
Review comment:
context 和go标准包冲突，别改成这样
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
