yhs0092 commented on a change in pull request #1953:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1953#discussion_r488347472
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsBootListener.java
##########
@@ -43,13 +42,10 @@ public SlowInvocationLogger getSlowInvocationLogger() {
@Override
public void onBeforeProducerProvider(BootEvent event) {
- if
(!DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.metrics.endpoint.enabled",
true).get()) {
+ if
(!DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.metrics.endpoint.enabled",
false).get()) {
Review comment:
Under the security sensitive circumstances, the users only want to
expose their business REST interfaces. If we keep the default value to be
`true`, they may expose these two REST interfaces by mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
