liubao68 commented on a change in pull request #1953:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1953#discussion_r488370901
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsBootListener.java
##########
@@ -43,13 +42,10 @@ public SlowInvocationLogger getSlowInvocationLogger() {
@Override
public void onBeforeProducerProvider(BootEvent event) {
- if
(!DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.metrics.endpoint.enabled",
true).get()) {
+ if
(!DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.metrics.endpoint.enabled",
false).get()) {
Review comment:
I think these two interfaces do not have any sensitive information. And
if the application is secrured , the two interfaces will be secured too. I
don't know why explode the two interface will cause security issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
