tianxiaoliang commented on a change in pull request #721:
URL:
https://github.com/apache/servicecomb-service-center/pull/721#discussion_r508168879
##########
File path: datasource/etcd/cache/etcd/cacher_kv_test.go
##########
@@ -34,19 +34,19 @@ import (
type mockCache struct {
Key string
- KV *discovery.KeyValue
+ KV *cache2.KeyValue
Review comment:
rename cache2 to sd
##########
File path: datasource/etcd/bootstrap/bootstrap.go
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package bootstrap
+
+//registry is buildin
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/client/buildin"
+
+//registry etcd
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/client/etcd"
+
+//registry etcd
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/client/embededetcd"
+
+//discovery
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/cache/aggregate"
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/cache/servicecenter"
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/cache/etcd"
+import _
"github.com/apache/servicecomb-service-center/datasource/etcd/cache/k8s"
Review comment:
rename cache to sd（service discovery）
##########
File path: datasource/etcd/cache/aggregate/indexer.go
##########
@@ -16,28 +16,28 @@
package aggregate
import (
+ "github.com/apache/servicecomb-service-center/datasource/etcd/cache"
+ registry
"github.com/apache/servicecomb-service-center/datasource/etcd/client"
"github.com/apache/servicecomb-service-center/pkg/util"
- "github.com/apache/servicecomb-service-center/server/plugin/discovery"
- "github.com/apache/servicecomb-service-center/server/plugin/registry"
"context"
)
-// AdaptorsIndexer implements discovery.Indexer.
+// AdaptorsIndexer implements pkg.Indexer.
Review comment:
pkg.Indexer is wrong
##########
File path: datasource/etcd/cache/etcd/indexer_cache.go
##########
@@ -18,23 +18,23 @@ package etcd
import (
"fmt"
+ "github.com/apache/servicecomb-service-center/datasource/etcd/cache"
+ registry
"github.com/apache/servicecomb-service-center/datasource/etcd/client"
Review comment:
since you rename registry to client, you use alias to replace client
again, wht is wierd. plz use registry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
