tianxiaoliang commented on a change in pull request #721:
URL:
https://github.com/apache/servicecomb-service-center/pull/721#discussion_r508169487
##########
File path: datasource/etcd/cache/etcd/indexer_cache.go
##########
@@ -18,23 +18,23 @@ package etcd
import (
"fmt"
+ "github.com/apache/servicecomb-service-center/datasource/etcd/cache"
+ registry
"github.com/apache/servicecomb-service-center/datasource/etcd/client"
Review comment:
since you rename registry to client, you use alias to replace client
again, that is wierd. plz use registry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
