tianxiaoliang commented on a change in pull request #759:
URL:
https://github.com/apache/servicecomb-service-center/pull/759#discussion_r531822882
##########
File path: datasource/mongo/ms_test.go
##########
@@ -650,3 +652,503 @@ func TestRuleUpdate(t *testing.T) {
// assert.Equal(t, 1, len(resSchemas.Schemas))
// })
//}
+
+func TestInstance_Creat(t *testing.T) {
+ var serviceId string
+
+ t.Run("create service", func(t *testing.T) {
+ insertRes, err :=
datasource.Instance().RegisterService(getContext(), &pb.CreateServiceRequest{
+ Service: &pb.MicroService{
Review comment:
UT要有上下文，动作，结果
例子：如果创建服务，且参数正确，应该成功
##########
File path: go.mod
##########
@@ -53,6 +53,7 @@ require (
github.com/urfave/cli v1.22.4
github.com/widuu/gojson v0.0.0-20170212122013-7da9d2cd949b
github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2 //
indirect
+ go.etcd.io/bbolt v1.3.5 // indirect
Review comment:
为何这里简介引入了bbolt？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
