xzccfzy commented on a change in pull request #759:
URL:
https://github.com/apache/servicecomb-service-center/pull/759#discussion_r532406240
##########
File path: datasource/mongo/heartbeat/heartbeatchecker/heartbeat.go
##########
@@ -19,24 +19,25 @@ package heartbeatchecker
import (
"context"
+ "fmt"
"github.com/apache/servicecomb-service-center/datasource/mongo"
"github.com/apache/servicecomb-service-center/datasource/mongo/client"
- "github.com/apache/servicecomb-service-center/pkg/log"
"go.mongodb.org/mongo-driver/bson"
+ "strings"
"time"
)
func updateInstanceRefreshTime(ctx context.Context, serviceID string,
instanceID string) error {
filter := bson.M{
- mongo.InstanceID: instanceID,
- mongo.ServiceID: serviceID,
+ strings.Join([]string{mongo.ColumnInstanceInfo,
mongo.ColumnInstanceID}, "."): instanceID,
Review comment:
直接使用 + 连接么？还是采用buffer.Builder？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
