DFSOrange commented on a change in pull request #800:
URL:
https://github.com/apache/servicecomb-service-center/pull/800#discussion_r549556683
##########
File path: syncer/grpc/grpc.go
##########
@@ -39,14 +39,18 @@ type Server struct {
stopCh chan struct{}
}
+const (
+ MaxMsgSize = 2147483647
Review comment:
math库
##########
File path: syncer/servicecenter/sync.go
##########
@@ -42,7 +43,11 @@ func (s *servicecenter) heartbeatInstances(mapping
pb.SyncMapping, instance *pb.
func (s *servicecenter) createService(service *pb.SyncService) string {
ctx := context.Background()
- serviceID, _ := s.servicecenter.ServiceExistence(ctx,
service.DomainProject, service)
+ serviceID, err := s.servicecenter.ServiceExistence(ctx,
service.DomainProject, service)
+ if err != nil {
+ log.Error("get service existence failed", err)
Review comment:
查询svc有err不返回继续创建？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
