tianxiaoliang commented on a change in pull request #800:
URL:
https://github.com/apache/servicecomb-service-center/pull/800#discussion_r549902955
##########
File path: syncer/servicecenter/sync.go
##########
@@ -42,15 +43,22 @@ func (s *servicecenter) heartbeatInstances(mapping
pb.SyncMapping, instance *pb.
func (s *servicecenter) createService(service *pb.SyncService) string {
Review comment:
这个方法应该明确返回err，而不是内部消化了，不知道有何特别的场景
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
