tianxiaoliang commented on a change in pull request #824:
URL:
https://github.com/apache/servicecomb-service-center/pull/824#discussion_r554979572
##########
File path: datasource/etcd/dep.go
##########
@@ -35,23 +37,23 @@ func (ds *DataSource) SearchProviderDependency(ctx
context.Context, request *pb.
providerServiceID := request.ServiceId
provider, err := serviceUtil.GetService(ctx, domainProject,
providerServiceID)
- if err != nil {
- log.Errorf(err, "GetProviderDependencies failed, provider is
%s", providerServiceID)
- return nil, err
- }
- if provider == nil {
- log.Errorf(err, "GetProviderDependencies failed for
provider[%s] does not exist", providerServiceID)
+ if errors.Is(err, datasource.ErrNoDocuments) {
Review comment:
其实嵌套一般在3层内就，这个明显适合嵌套，更加易读
##########
File path: datasource/etcd/dep.go
##########
@@ -35,23 +37,23 @@ func (ds *DataSource) SearchProviderDependency(ctx
context.Context, request *pb.
providerServiceID := request.ServiceId
provider, err := serviceUtil.GetService(ctx, domainProject,
providerServiceID)
- if err != nil {
- log.Errorf(err, "GetProviderDependencies failed, provider is
%s", providerServiceID)
- return nil, err
- }
- if provider == nil {
- log.Errorf(err, "GetProviderDependencies failed for
provider[%s] does not exist", providerServiceID)
+ if errors.Is(err, datasource.ErrNoDocuments) {
+ log.Error(fmt.Sprintf("GetProviderDependencies failed for
provider[%s] does not exist", providerServiceID), err)
return &pb.GetProDependenciesResponse{
Response: pb.CreateResponse(pb.ErrServiceNotExists,
"Provider does not exist"),
}, nil
}
+ if err != nil {
+ log.Error(fmt.Sprintf("GetProviderDependencies failed, provider
is %s", providerServiceID), err)
Review comment:
这类日志打印没有意义
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
