tianxiaoliang commented on a change in pull request #824:
URL:
https://github.com/apache/servicecomb-service-center/pull/824#discussion_r555694768
##########
File path: datasource/etcd/dep.go
##########
@@ -36,22 +38,23 @@ func (ds *DataSource) SearchProviderDependency(ctx
context.Context, request *pb.
provider, err := serviceUtil.GetService(ctx, domainProject,
providerServiceID)
if err != nil {
- log.Errorf(err, "GetProviderDependencies failed, provider is
%s", providerServiceID)
- return nil, err
- }
- if provider == nil {
- log.Errorf(err, "GetProviderDependencies failed for
provider[%s] does not exist", providerServiceID)
- return &pb.GetProDependenciesResponse{
- Response: pb.CreateResponse(pb.ErrServiceNotExists,
"Provider does not exist"),
- }, nil
+ if errors.Is(err, datasource.ErrNoData) {
+ log.Debug(fmt.Sprintf("provider[%s] does not exist in
db", providerServiceID))
+ return &pb.GetProDependenciesResponse{
+ Response:
pb.CreateResponse(pb.ErrServiceNotExists, "Provider does not exist"),
+ }, nil
+ } else {
Review comment:
不需要else，你再看下，代码不需要冗余的else，执行效果是一样的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
