little-cui commented on a change in pull request #228:
URL: https://github.com/apache/servicecomb-kie/pull/228#discussion_r757723947
##########
File path: .github/workflows/mongo_storage.yml
##########
@@ -13,10 +13,7 @@ jobs:
uses: actions/checkout@v1
- name: UT
run: |
- cd build
Review comment:
建议另起一个并行的task，用于验证docker build的脚本，而不是因为没依赖而删掉
##########
File path: deployments/docker/mongo-compose.yaml
##########
@@ -0,0 +1,32 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+version: '3.3'
+services:
+ mongo:
+ image: mongo:4.2
+ command: mongod --replSet my-replica-set --port 27017 --bind_ip_all
Review comment:
此脚本直接替换example/dev/docker-compose.yaml会更好，而不是新增一个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
