robotLJW commented on a change in pull request #228:
URL: https://github.com/apache/servicecomb-kie/pull/228#discussion_r758087726
##########
File path: server/datasource/dao.go
##########
@@ -70,13 +74,14 @@ func GetBroker() Broker {
//KVDao provide api of KV entity
type KVDao interface {
// Create Update List are usually for admin console
- Create(ctx context.Context, kv *model.KVDoc) (*model.KVDoc, error)
- Update(ctx context.Context, kv *model.KVDoc) error
+ Create(ctx context.Context, kv *model.KVDoc, options ...WriteOption)
(*model.KVDoc, error)
Review comment:
测试用例后面再补充，不好再service层加上开关参数，后面修改这容易将这个参数遗漏，还是需要 dao
层做验证，但是目前对task和tombstone的dao层没有写，无法做验证，后续补充sync的测试用例
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
