tianxiaoliang commented on a change in pull request #1185:
URL:
https://github.com/apache/servicecomb-service-center/pull/1185#discussion_r774890406
##########
File path: eventbase/datasource/mongo/tombstone/tombstone_dao_test.go
##########
@@ -87,10 +89,10 @@ func TestTombstone(t *testing.T) {
})
t.Run("list tombstone", func(t *testing.T) {
- t.Run("list tombstone with ResourceType and BeforeTimestamp
should pass", func(t *testing.T) {
+ t.Run("list tombstone with Domain, Project ,ResourceType and
BeforeTimestamp should pass", func(t *testing.T) {
opts := []datasource.TombstoneFindOption{
datasource.WithTombstoneDomain("default"),
- datasource.WithTombstoneProject("default"),
+ datasource.WithTombstoneDomain("default"),
Review comment:
作为默认就不该让调用方自己填默认值
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
