tianxiaoliang commented on a change in pull request #1185:
URL:
https://github.com/apache/servicecomb-service-center/pull/1185#discussion_r774891244
##########
File path: eventbase/datasource/etcd/task/task_dao_test.go
##########
@@ -141,6 +138,13 @@ func TestTask(t *testing.T) {
t.Run("delete tasks should pass", func(t *testing.T) {
err := ds.TaskDao().Delete(context.Background(),
[]*sync.Task{&task, &taskTwo, &taskThree}...)
assert.NoError(t, err)
+ opts := []datasource.TaskFindOption{
+ datasource.WithDomain("default"),
Review comment:
这里没错，不要被我上一个comment引导错误，因为domain和project不该提供默认值，我认为2个都是不该有默认值的，所以的确应该指明参数来查询
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
