little-cui commented on a change in pull request #1204:
URL:
https://github.com/apache/servicecomb-service-center/pull/1204#discussion_r779382789
##########
File path: datasource/etcd/ms.go
##########
@@ -1737,10 +1749,34 @@ func (ds *MetadataManager) DeleteTags(ctx
context.Context, request *pb.DeleteSer
key := path.GenerateServiceTagKey(domainProject, request.ServiceId)
- resp, err := etcdadpt.TxnWithCmp(ctx,
- etcdadpt.Ops(etcdadpt.OpPut(etcdadpt.WithStrKey(key),
etcdadpt.WithValue(data))),
-
etcdadpt.If(etcdadpt.NotEqualVer(path.GenerateServiceKey(domainProject,
request.ServiceId), 0)),
- nil)
+ opts := etcdadpt.Ops(etcdadpt.OpPut(etcdadpt.WithStrKey(key),
etcdadpt.WithValue(data)))
+ if datasource.EnableSync {
+ domain := util.ParseDomain(ctx)
+ project := util.ParseProject(ctx)
+ taskOpt, err := eutil.GenTaskOpts(&eutil.TaskOpt{
+ Domain: domain,
+ Project: project,
+ Action: sync.DeleteAction,
+ ResourceType: datasource.ResourceKV,
+ Resource: data,
+ Opts: map[string]string{"key": key},
+ })
+ if err != nil {
+ return &pb.DeleteServiceTagsResponse{
+ Response: pb.CreateResponse(pb.ErrInternal,
err.Error()),
+ }, err
+ }
+ tombstoneOpt, err := eutil.GenTombstoneOpts(domain, project,
datasource.ResourceKV, key)
Review comment:
Delete事务落盘，必须伴随墓碑，是否能进步一抽取函数，而不是分开写
##########
File path: datasource/etcd/dep.go
##########
@@ -31,7 +31,7 @@ import (
"github.com/apache/servicecomb-service-center/datasource/etcd/event"
"github.com/apache/servicecomb-service-center/datasource/etcd/path"
"github.com/apache/servicecomb-service-center/datasource/etcd/sd"
- serviceUtil
"github.com/apache/servicecomb-service-center/datasource/etcd/util"
+ eutil
"github.com/apache/servicecomb-service-center/datasource/etcd/util"
Review comment:
改名的原因：？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
