robotLJW commented on a change in pull request #1204:
URL:
https://github.com/apache/servicecomb-service-center/pull/1204#discussion_r779979639
##########
File path: datasource/etcd/account.go
##########
@@ -194,20 +195,15 @@ func (ds *RbacDAO) DeleteAccount(ctx context.Context,
names []string) (bool, err
continue //do not fail if some account is invalid
}
- if datasource.EnableSync {
- taskOpt, err := GenTaskOpts("", "", sync.DeleteAction,
datasource.ResourceAccount, a)
- if err != nil {
- log.Error("", err)
- return false, err
- }
- tombstoneOpt, err := GenTombstoneOpts("", "",
datasource.ResourceAccount, a.Name)
- if err != nil {
- log.Error("", err)
- return false, err
- }
- opts = append(opts, tombstoneOpt, taskOpt)
+ syncOpts, err := esync.GenSyncOpts(ctx, sync.DeleteAction,
datasource.ResourceAccount, a, esync.WithResourceID(a.Name))
Review comment:
华哥这个resourceID是删除的时候需要必填的，其他操作时不用填写的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
