shoothzj commented on code in PR #4104:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4104#discussion_r1419018440
##########
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestOsMeterInitializer.java:
##########
@@ -55,64 +58,57 @@ public void init() {
list.add("13 1 1 1 1 1 1 1 1 0 0 1 1 1 1 1 1 1 1 1 1 1 1 1");
list.add("useless");
list.add("eth0: 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0");
- new MockUp<CharSource>() {
- //Files.readFirstLine
- @Mock
- public String readFirstLine() {
- return list.get(0);
- }
- };
- new MockUp<FileUtils>() {
- @Mock
- public List<String> readLines(File file, Charset encoding) {
- return list;
- }
- };
- OsMetersInitializer osMetersInitializer = new OsMetersInitializer();
- osMetersInitializer.init(registry, eventBus, null);
+ try (MockedStatic<FileUtils> fileUtilsMockedStatic =
Mockito.mockStatic(FileUtils.class);
+ MockedStatic<CharSource> charSourceStatic =
Mockito.mockStatic(CharSource.class)) {
+ fileUtilsMockedStatic.when(() -> {
+ FileUtils.readLines(Mockito.any(File.class),
Mockito.any(Charset.class));
+ }).thenReturn(list);
+ OsMetersInitializer osMetersInitializer = new OsMetersInitializer();
+ osMetersInitializer.init(registry, eventBus, null);
- OsMeter osMeter = osMetersInitializer.getOsMeter();
- SystemMeter systemMeter = osMeter.getCpuMeter();
- OperatingSystemMXBean osBean = Mockito.mock(OperatingSystemMXBean.class);
- Mockito.when(osBean.getCpuLoad()).thenReturn(3.2D);
- Mockito.when(osBean.getProcessCpuLoad()).thenReturn(1.2D);
- systemMeter.setOsBean(osBean);
- NetMeter netMeter = osMeter.getNetMeter();
- netMeter.setOsLinux(true);
+ OsMeter osMeter = osMetersInitializer.getOsMeter();
+ SystemMeter systemMeter = osMeter.getCpuMeter();
+ OperatingSystemMXBean osBean = Mockito.mock(OperatingSystemMXBean.class);
+ Mockito.when(osBean.getCpuLoad()).thenReturn(3.2D);
+ Mockito.when(osBean.getProcessCpuLoad()).thenReturn(1.2D);
+ systemMeter.setOsBean(osBean);
+ NetMeter netMeter = osMeter.getNetMeter();
+ netMeter.setOsLinux(true);
- osMetersInitializer.poll(System.currentTimeMillis(), 1000);
+ osMetersInitializer.poll(System.currentTimeMillis(), 1000);
- MeasurementTree tree = new MeasurementTree();
- MeasurementGroupConfig group = new MeasurementGroupConfig();
- group.addGroup(OsMeter.OS_NAME, OsMeter.OS_TYPE);
- tree.from(registry.getMeters().iterator(), group);
+ MeasurementTree tree = new MeasurementTree();
+ MeasurementGroupConfig group = new MeasurementGroupConfig();
+ group.addGroup(OsMeter.OS_NAME, OsMeter.OS_TYPE);
+ tree.from(registry.getMeters().iterator(), group);
- Assertions.assertEquals(1.2D,
- tree.findChild(OsMeter.OS_NAME,
SystemMeter.PROCESS_CPU_USAGE).summary(), 0.0);
- Assertions.assertEquals(3.2D,
- tree.findChild(OsMeter.OS_NAME, SystemMeter.CPU_USAGE).summary(), 0.0);
+ Assertions.assertEquals(1.2D,
+ tree.findChild(OsMeter.OS_NAME,
SystemMeter.PROCESS_CPU_USAGE).summary(), 0.0);
+ Assertions.assertEquals(3.2D,
+ tree.findChild(OsMeter.OS_NAME,
SystemMeter.CPU_USAGE).summary(), 0.0);
- Map<String, InterfaceUsage> interfaceInfoMap =
netMeter.getInterfaceUsageMap();
- Assertions.assertEquals(1, interfaceInfoMap.size());
- InterfaceUsage eth0 = interfaceInfoMap.get("eth0");
- // recv Bps
- Assertions.assertEquals(0L, eth0.getReceive().getLastValue());
- Assertions.assertEquals(0, eth0.getReceive().getRate(), 0.0);
- Assertions.assertEquals(0, eth0.getReceive().getIndex());
- // send Bps
- Assertions.assertEquals(0L, eth0.getSend().getLastValue());
- Assertions.assertEquals(0, eth0.getSend().getRate(), 0.0);
- Assertions.assertEquals(8, eth0.getSend().getIndex());
+ Map<String, InterfaceUsage> interfaceInfoMap =
netMeter.getInterfaceUsageMap();
+ Assertions.assertEquals(1, interfaceInfoMap.size());
Review Comment:
plz don't change this intent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
