shoothzj commented on code in PR #4104:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4104#discussion_r1419761310
##########
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/meter/os/TestSystemMeter.java:
##########
@@ -35,63 +36,57 @@
import io.micrometer.core.instrument.MeterRegistry;
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
-import mockit.Mock;
-import mockit.MockUp;
-import mockit.Mocked;
public class TestSystemMeter {
@Test
- public void testCalcMeasurement(@Mocked CharSource charSource) throws
IOException {
+ public void testCalcMeasurement() throws IOException {
MeterRegistry meterRegistry = new SimpleMeterRegistry();
-
+ CharSource charSource = Mockito.mock(CharSource.class);
List<String> list = new ArrayList<>();
list.add("useless");
list.add("useless");
list.add("eth0: 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0");
- new MockUp<FileUtils>() {
- @Mock
- public List<String> readLines(File file, Charset encoding) {
- return list;
- }
- };
- new MockUp<Files>() {
- @Mock
- public CharSource asCharSource(File file, Charset encoding) {
- return charSource;
- }
- };
+ try (MockedStatic<FileUtils> fileUtilsMockedStatic =
Mockito.mockStatic(FileUtils.class);
+ MockedStatic<Files> filesMockedStatic =
Mockito.mockStatic(Files.class)) {
+ fileUtilsMockedStatic.when(() -> {
+ FileUtils.readLines(Mockito.any(File.class),
Mockito.any(Charset.class));
+ }).thenReturn(list);
+ filesMockedStatic.when(() -> {
+ Files.asCharSource(Mockito.any(File.class),
Mockito.any(Charset.class));
+ }).thenReturn(charSource);
- OsMeter osMeter = new OsMeter(meterRegistry);
- list.clear();
- list.add("useless");
- list.add("useless");
- list.add("eth0: 1 1 0 0 0 0 0 1 1 1
1 0 0 0 0 0");
+ OsMeter osMeter = new OsMeter(meterRegistry);
Review Comment:
wrong intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
