liubao68 commented on code in PR #4670:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4670#discussion_r1903748616
##########
foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/DiscoveryManager.java:
##########
@@ -178,7 +178,8 @@ private VersionedCache calcAvailableInstance(String
application, String serviceN
-> new ConcurrentHashMapEx<>());
List<StatefulDiscoveryInstance> result = new ArrayList<>();
for (StatefulDiscoveryInstance instance : statefulInstances.values()) {
- if (instance.getHistoryStatus() == HistoryStatus.CURRENT) {
+ if (instance.getHistoryStatus() == HistoryStatus.CURRENT
+ && instance.getMicroserviceInstanceStatus() ==
MicroserviceInstanceStatus.UP) {
result.add(instance);
continue;
}
Review Comment:
Non `UP` status should added to list. `InstanceStatusDiscoveryFilter` will
handle status priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
