liubao68 commented on code in PR #4670:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4670#discussion_r1903752469
##########
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/registry/sc/MicroserviceHandler.java:
##########
@@ -142,7 +142,11 @@ public static MicroserviceInstance
createMicroserviceInstance(
properties.putAll(BootStrapProperties.readServiceProperties(environment));
properties.putAll(genCasProperties(environment));
microserviceInstance.setProperties(properties);
-
microserviceInstance.setStatus(MicroserviceInstanceStatus.valueOf(scConfigurationProperties.getInitialStatus()));
+ if (scConfigurationProperties.isEnableElegantUpDown()){
+ microserviceInstance.setStatus(MicroserviceInstanceStatus.STARTING);
+ }else {
+ microserviceInstance.setStatus(MicroserviceInstanceStatus.UP);
+ }
Review Comment:
Maybe do not need this modification. Users can configure initial status to
STARTING when need elegant up down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
