chenshouye168 commented on code in PR #4670:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4670#discussion_r1908331926
##########
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/registry/sc/MicroserviceHandler.java:
##########
@@ -142,7 +142,11 @@ public static MicroserviceInstance
createMicroserviceInstance(
properties.putAll(BootStrapProperties.readServiceProperties(environment));
properties.putAll(genCasProperties(environment));
microserviceInstance.setProperties(properties);
-
microserviceInstance.setStatus(MicroserviceInstanceStatus.valueOf(scConfigurationProperties.getInitialStatus()));
+ if (scConfigurationProperties.isEnableElegantUpDown()){
+ microserviceInstance.setStatus(MicroserviceInstanceStatus.STARTING);
+ }else {
+ microserviceInstance.setStatus(MicroserviceInstanceStatus.UP);
+ }
Review Comment:
don`t need it ,have removed
##########
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/registry/sc/SCConfigurationProperties.java:
##########
@@ -171,4 +173,12 @@ public boolean isEnableSwaggerRegistration() {
public void setEnableSwaggerRegistration(boolean enableSwaggerRegistration) {
this.enableSwaggerRegistration = enableSwaggerRegistration;
}
+
+ public boolean isEnableElegantUpDown() {
+ return enableElegantUpDown;
+ }
+
+ public void setEnableElegantUpDown(boolean enableElegantUpDown) {
+ this.enableElegantUpDown = enableElegantUpDown;
+ }
Review Comment:
don`t need it ,have removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
