chenshouye168 commented on code in PR #4670:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4670#discussion_r1908356202
##########
core/src/main/java/org/apache/servicecomb/core/SCBEngine.java:
##########
@@ -371,7 +371,7 @@ private void doRun() throws Exception {
registrationManager.run();
discoveryManager.run();
// ensure can invoke services in AFTER_REGISTRY
-
registrationManager.updateMicroserviceInstanceStatus(MicroserviceInstanceStatus.UP);
+//
registrationManager.updateMicroserviceInstanceStatus(MicroserviceInstanceStatus.UP);
Review Comment:
Checked the code, only service-center implements this method, the other
registry just return true, the initialization status to properties/yml inside,
the default is true, the registration status is also true, I think it will not
affect the compatibility of this line of code to remove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
