liubao68 commented on code in PR #4670:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4670#discussion_r1908398698
##########
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/registry/sc/MicroserviceHandler.java:
##########
@@ -113,13 +113,13 @@ public static MicroserviceInstance
createMicroserviceInstance(
}
microserviceInstance.setHostName(hostName);
+ DataCenterInfo dataCenterInfo = new DataCenterInfo();
if (StringUtils.isNotEmpty(dataCenterProperties.getName())) {
- DataCenterInfo dataCenterInfo = new DataCenterInfo();
dataCenterInfo.setName(dataCenterProperties.getName());
dataCenterInfo.setRegion(dataCenterProperties.getRegion());
dataCenterInfo.setAvailableZone(dataCenterProperties.getAvailableZone());
- microserviceInstance.setDataCenterInfo(dataCenterInfo);
}
+ microserviceInstance.setDataCenterInfo(dataCenterInfo);
Review Comment:
Do not change this, it's an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
