bdemers commented on pull request #239: URL: https://github.com/apache/shiro/pull/239#issuecomment-644271663
We should probably filter these files in if/when needed, possibly just in the core/lang module (and if they get repackaged in the `all` module). Or copy a single static NOTICE file in from the root (instead of duplicating it) Ideas: A side note, we can also use the `org.jasig.maven:maven-notice-plugin` plugin to generate a notice https://github.com/paseto-toolkit/jpaseto/blob/master/pom.xml#L239-L251 (**NOTE:** the usage above differs from the ASF requirements) Another trick is to define a `root.dir` property: in the parent pom: ```xml <root.dir>${session.executionRootDirectory}</root.dir> ``` And include the resource as `${root.dir}/NOTICE` But... depending on how maven multi-modules are being used in the project it _might_ be easier to reference them as `../../NOTICE` instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
