bdemers commented on pull request #239: URL: https://github.com/apache/shiro/pull/239#issuecomment-644331776
OHHH, I see now. I didn't realize where that was coming from. We can probably get away with the template for most modules. And only include a custom NOTICE (just copied in as you have) in the modules were needed (for example `lang`) But I'm not sure if/how the bundle plugin plays into this, because IIRC the bundle plugin repacks some of the dependencies? We could also "skip" this plugin's execution and make sure the LICENSE & NOTICE files are included by other means. Anyway, I'm not trying to create more work just to work around a NOTICE bundling issue. If you can simplify it, great, if not, what you have in this PR is legally correct (which is more important) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
