fpapon commented on a change in pull request #242:
URL: https://github.com/apache/shiro/pull/242#discussion_r445354700
##########
File path: web/src/main/java/org/apache/shiro/web/env/IniWebEnvironment.java
##########
@@ -263,20 +263,13 @@ protected FilterChainResolver createFilterChainResolver()
{
Ini ini = getIni();
if (!CollectionUtils.isEmpty(ini)) {
- //only create a resolver if the 'filters' or 'urls' sections are
defined:
Review comment:
> I'd like to see a comment here, if you don't mind:
> `// SHIRO-610: Allow creation of FilterChainResolver even without urls and
filters sections.`
@bmhm I'm not a big fan to add the jira related informations, we already
have the git commit history for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
