bmhm commented on a change in pull request #242:
URL: https://github.com/apache/shiro/pull/242#discussion_r445378030
##########
File path: web/src/main/java/org/apache/shiro/web/env/IniWebEnvironment.java
##########
@@ -263,20 +263,13 @@ protected FilterChainResolver createFilterChainResolver()
{
Ini ini = getIni();
if (!CollectionUtils.isEmpty(ini)) {
- //only create a resolver if the 'filters' or 'urls' sections are
defined:
Review comment:
Alright. I was requesting this because we had security-related code
changes which could have been prevented by such comments. Why? Because you do
not always look into the history before accepting code or changing code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
