bdemers commented on a change in pull request #273:
URL: https://github.com/apache/shiro/pull/273#discussion_r554021392



##########
File path: crypto/hash/src/main/java/org/apache/shiro/crypto/hash/Md2Hash.java
##########
@@ -30,10 +30,13 @@
  * techniques and how the overloaded constructors function.
  *
  * @since 0.9
+ * @deprecated and will throw exceptions since 2.0.0, to be removed in 2.1.0.

Review comment:
       we can also mark them deprecated now, and then remove all the deprecated 
bits before the official 2.0 release if you are on the fence about anything.
   
   Another idea, is we could nag users: print a log message: "WARN: Seriously, 
stop using MD2, here is why <insert some URL here>" 👺 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to