bmarwell commented on a change in pull request #273:
URL: https://github.com/apache/shiro/pull/273#discussion_r554347551
##########
File path: tools/hasher/pom.xml
##########
@@ -50,7 +50,11 @@
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
- <artifactId>slf4j-simple</artifactId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
Review comment:
It is not so funny actually. See the chat in slack. To be able test
things written to `System.out`, we need `logback-classic`, as the
`simple-logger` cannot be intercepted.
Romain suggested to refactor the hasher utility a bit further, and I would
like to do that in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
