bdemers commented on a change in pull request #297:
URL: https://github.com/apache/shiro/pull/297#discussion_r626674074
##########
File path:
crypto/cipher/src/main/java/org/apache/shiro/crypto/AesCipherService.java
##########
@@ -89,12 +89,16 @@
* <b>**</b>Since {@code GCM} is a stream cipher, padding is implemented
in the operation mode and an external padding scheme
* cannot be used in conjunction with {@code GCM}. In fact, {@code
AES/GCM/PKCS5Padding} is just an alias in most JVM for
* {@code AES/GCM/NoPadding}.
+ * <p/>
+ * <b>NOTE:</b> As of Java 14, setting a streaming padding for the above
example will throw a NoSuchAlgorithmException
+ * @see <a
href="https://www.oracle.com/java/technologies/javase/14-relnote-issues.html#JDK-8180392";>JDK-8180392</a>
Review comment:
I'll merge this line back to master
##########
File path:
crypto/cipher/src/main/java/org/apache/shiro/crypto/AesCipherService.java
##########
@@ -89,12 +89,16 @@
* <b>**</b>Since {@code GCM} is a stream cipher, padding is implemented
in the operation mode and an external padding scheme
* cannot be used in conjunction with {@code GCM}. In fact, {@code
AES/GCM/PKCS5Padding} is just an alias in most JVM for
* {@code AES/GCM/NoPadding}.
+ * <p/>
+ * <b>NOTE:</b> As of Java 14, setting a streaming padding for the above
example will throw a NoSuchAlgorithmException
+ * @see <a
href="https://www.oracle.com/java/technologies/javase/14-relnote-issues.html#JDK-8180392";>JDK-8180392</a>
Review comment:
I'll merge this line back to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
