bdemers commented on a change in pull request #297:
URL: https://github.com/apache/shiro/pull/297#discussion_r627466016
##########
File path: Jenkinsfile-jdk11
##########
@@ -72,14 +72,15 @@ pipeline {
stage('Build') {
steps {
echo 'Building'
- sh 'mvn -U -B -e clean install -DskipTests apache-rat:check'
+ sh 'mvn -U -B -e apache-rat:check'
Review comment:
+1 for this, but I'm going to move it in its own stage for now, and try
to remove the duplication between these files on `main`.
Hopefully something like this in each Jenkins file:
```groovy
const jdkVersion = 'jdk_8_latest'
const deploy = false
const rat = false
const supportedBranch = (env.BRANCH_NAME == "1.7.x" || env.BRANCH_NAME ==
"1.8.x" || env.BRANCH_NAME == "main") // we have a lot of this in the
individual files
load('Jenkinsfile-common')
}
```
I'm not sure that will work (given the scope of those globals 🤮), but I'll
poke around with it
##########
File path: Jenkinsfile-jdk11
##########
@@ -72,14 +72,15 @@ pipeline {
stage('Build') {
steps {
echo 'Building'
- sh 'mvn -U -B -e clean install -DskipTests apache-rat:check'
+ sh 'mvn -U -B -e apache-rat:check'
Review comment:
+1 for this, but I'm going to move it in its own stage for now, and try
to remove the duplication between these files on `main`.
Hopefully something like this in each Jenkins file:
```groovy
const jdkVersion = 'jdk_8_latest'
const deploy = false
const rat = false
const supportedBranch = (env.BRANCH_NAME == "1.7.x" || env.BRANCH_NAME ==
"1.8.x" || env.BRANCH_NAME == "main") // we have a lot of this in the
individual files
load('Jenkinsfile-common')
```
I'm not sure that will work (given the scope of those globals 🤮), but I'll
poke around with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
