steinarb commented on code in PR #2772:
URL: https://github.com/apache/shiro/pull/2772#discussion_r3421701560
##########
core/src/main/java/org/apache/shiro/realm/ldap/LdapUtils.java:
##########
@@ -69,8 +69,8 @@ public static void closeContext(LdapContext ctx) {
* @throws javax.naming.NamingException if there is an LDAP error while
reading the values.
*/
public static Collection<String> getAllAttributeValues(Attribute attr)
throws NamingException {
- Set<String> values = new HashSet<String>();
- NamingEnumeration ne = null;
+ Set<String> values = new HashSet<>();
Review Comment:
Since you're moving to new syntax anyway: why not var for all local
variables where it is possible to use it?
Would be like this then:
```
var values = new HashSet<String>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
